Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: use NewType for ID objects #10

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Internal: use NewType for ID objects #10

merged 1 commit into from
Sep 25, 2023

Conversation

odesenfans
Copy link
Contributor

@odesenfans odesenfans commented Sep 22, 2023 •
edited
Loading

Problem: ID objects (request ID, execution ID, nonce) all use raw string/int objects. This could lead to using the wrong object in the wrong place without noticing.

Solution: define dedicated types for each object type.

@odesenfans
Internal: use NewType for ID objects
7d21d73 
Problem: ID objects (request ID, execution ID, nonce) all use raw
string/int objects. This could lead to using the wrong object in the
wrong place without noticing.

Solution: defined dedicated types for each object type.
@odesenfans odesenfans mentioned this pull request Sep 22, 2023
Open
@odesenfans odesenfans merged commit 681ae5f into main Sep 25, 2023
4 checks passed
@odesenfans odesenfans deleted the od-use-newtypes branch September 25, 2023 10:14
nesitor
nesitor reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesitor nesitor nesitor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odesenfans @nesitor